Conversation
According to the documentation of sendpay:
Calls to sendpay with the same payment_hash,
amount_msat, and destination as a previous
successful payment (even if a different route
or partid) will return immediately with success.
A self payment is a special case, but the destination being
always ourselves should follow the same rule.
Changelog-Fixed: sendpay: immediate success when replaying a completed self payment.
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Lagrang3
force-pushed
the
fix/sendpay-replay-selfpayment
branch
from
September 16, 2026 07:44
0a411a6 to
6dc8523
Compare
Andezion
approved these changes
Sep 16, 2026
Andezion
left a comment
Andezion
left a comment
Collaborator
There was a problem hiding this comment.
not caused by this pr, but noticed while reviewing, that self_payment() never calls check_invoice_request_usage()? (unlike send_payment_core at pay.c at line 1111), so bolt12 invoice-request usage isnt tracked/enforced for self-payments even on the non-replay path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documentation of sendpay:
A self payment is a special case, but the destination being always ourselves should follow the same rule.
Changelog-Fixed: sendpay: inmediately success when replaying a completed self payment.